Hello, The Coccinelle software pointed out that the function "lmc_ioctl" is an update candidate according to the message "opportunity for memdup_user". https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/net/wan/lmc/lmc_main.c?id=6040e57658eee6eb1315a26119101ca832d1f854#n486
I guess that it would be nice to improve also this implementation. But there are further constraints to consider. The script "checkpatch.pl" can point information out like the following. * ERROR: code indent should use tabs where possible * WARNING: please, no spaces at the start of a line The source files for this software module contain also some open issues for the preferred source code formatting. * How should these places be fixed so that they will match the current Linux coding style before additional adjustments can be safely tried? * Would you like to suggest any advanced tools (besides "scripts/cleanfile") for a corresponding source code beautification? Which pretty-printing approaches are acceptable for Linux so far? Regards, Markus
