On Sat, Aug 20, 2016 at 02:41:01PM +0800, Xin Long wrote: > > Ah, I see what you're doing. Ok, this makes some sense, at least on the > > receive > > side, when you get a cookie unpacked and modify the remote peers address > > list, > > it makes sense to check for duplicates. On the local side however, I would, > > instead of checking it when the list gets copied, I'd check it when the > > master > > list gets updated (in the NETDEV_UP event notifier for the local address > > list, > > I was thinking about to check it in the NETDEV_UP, yes it can make the > master list has no duplicated addresses. But what if two same addresses > events come, and they come from different NICs (though I can't point out > the valid use case), then we filter there. > That I think would be a bug in the protocol code. For the ipv4 case, all addresses are owned by the system and the same addresses added to multiple interfaces should not be allowed. The same is true of ipv6 case. The only exception there is a link local address and that should still be unique within the context of an address/dev tuple.
> Later, sctp may receive one NETDEV_DOWN event,sctp will remove that > addr in the master list, but it shouldn't have been removed, as another local > NIC still has that addr. > > That's why I have to leave the master alone, just check when they are really > being bind to asoc addr list. > > > and the sctp_add_bind_addr function for the endpoint address list). That > > way > > As to the endpoint address list, sctp has different process for binding > the address 'ANY' from assoc address list (note that this issue only > happened in binding the address 'ANY'). instead of copying the master > address list to the endpoint, it only adds address 'ANY' to the EP > address list. Only when starting a connection and create the assoc, it > copy the master address list to ASOC. > > So no need to do it in sctp_add_bind_addr for endpoint address list. > Besides, sctp_add_bind_addr is supposed to be called after checking > the duplicated address(I got it from sctp_do_bind()). :-) > > > you can keep that nested for loop out of the send path on the local system. > > > > >
