Ron Mercer <[EMAIL PROTECTED]> : [...] > Looking forward to any and all feedback.
First pass: - please reorder the code so that the forward declarations are not needed - the typedefs (say PQL3XXX_PORT_REGISTERS) hide pointer information. They are useless (and capitalized :o/ ). Just say no to typedef. - the debug functions abuse copy/paste. Please use struct array + loop if you really want these to stay. - "return" is not a function. It does not need parenthesis. - 80 colums disease in ql_link_state_machine. The indentation is terrible. - label for goto should be at the start of the line. - acquire_adapter_lock must go. Conditional locking is a pain to maintain. - the error path in ql3xxx_probe is broken. Use named _and_ numbered goto if you want to avoid it (i.e. "goto err_undo_something_1" then "goto err_undo_something_else_2", etc.). - ql_set_ethtool_ops() is useless bloat. Please remove. - QL_LOCK_DRVR_WAIT should be a function, not a macro - the status code should be propagated (request_irq, pci_enable_device, pci_request_regions, etc.). - no __iomem, __u32, __le32 ? Seems strange. - replace return (0) with NETDEV_TX_OK in ql3xxx_send (and s/send/start_xmit/ ?). -- Ueimor - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
