On Wed, Aug 24, 2016 at 11:53 AM, David Ahern <d...@cumulusnetworks.com> wrote: > On 8/24/16 11:41 AM, pravin shelar wrote: >> You also need to change pop_mpls(). > > What change is needed in pop_mpls? It already resets the mac_header and if > MPLS labels are removed there is no need to set network_header. I take it you > mean if the protocol is still MPLS and there are still labels then the > network header needs to be set and that means finding the bottom label. Does > OVS set the bottom of stack bit? From what I can tell OVS is not parsing the > MPLS label so no requirement that BOS is set. Without that there is no way to > tell when the labels are done short of guessing. >
OVS mpls push and pop action works on outer most mpls label. So according to new mpls offsets tracking scheme on mpls_pop action you need to adjust skb network offset.
