On Mon, Aug 29, 2016 at 01:03:23PM +0800, sean.w...@mediatek.com wrote:
> From: Sean Wang <sean.w...@mediatek.com>
>
> return -ENODEV if no child is found in MDIO bus.
The "no child" is wrong here, and got me confused. What the code is
actually doing is of_device_is_available() which is looking to see if
there is a status = "okay". So what the change log should say is:
Return -ENODEV if the MDIO bus is disabled in the device tree.
Once that has been corrected:
Reviewed-by: Andrew Lunn <and...@lunn.ch>
Andrew
>
> Signed-off-by: Sean Wang <sean.w...@mediatek.com>
> Acked-by: John Crispin <j...@phrozen.org>
> ---
> drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index f741c6a..e48b2a4 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -304,7 +304,7 @@ static int mtk_mdio_init(struct mtk_eth *eth)
> }
>
> if (!of_device_is_available(mii_np)) {
> - ret = 0;
> + ret = -ENODEV;
> goto err_put_node;
> }
>
> --
> 1.9.1
>
