On Tue, Aug 30, 2016 at 7:38 AM, Ivan Vecera <ivec...@redhat.com> wrote: > The recent commit 087d7a8c disallows to set Rx coalescing time to be 0 > as this stops generating interrupts for the incoming packets. I found > the zero Tx coalescing time stops generating interrupts similarly for > outgoing packets and fires Tx watchdog later. To avoid this, don't allow > to set Tx coalescing time to 0. > > Cc: satish.baddipad...@broadcom.com > Cc: siva.kal...@broadcom.com > Cc: michael.c...@broadcom.com > Signed-off-by: Ivan Vecera <ivec...@redhat.com> > --- > drivers/net/ethernet/broadcom/tg3.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/broadcom/tg3.c > b/drivers/net/ethernet/broadcom/tg3.c > index 6592612..07e3beb 100644 > --- a/drivers/net/ethernet/broadcom/tg3.c > +++ b/drivers/net/ethernet/broadcom/tg3.c > @@ -14012,6 +14012,7 @@ static int tg3_set_coalesce(struct net_device *dev, > struct ethtool_coalesce *ec) > if ((ec->rx_coalesce_usecs > MAX_RXCOL_TICKS) || > (!ec->rx_coalesce_usecs) || > (ec->tx_coalesce_usecs > MAX_TXCOL_TICKS) || > + (!ec->tx_coalesce_usecs) || > (ec->rx_max_coalesced_frames > MAX_RXMAX_FRAMES) || > (ec->tx_max_coalesced_frames > MAX_TXMAX_FRAMES) || > (ec->rx_coalesce_usecs_irq > max_rxcoal_tick_int) ||
As Rick pointed out last time, we can remove this check which follows the block of code above: /* No tx interrupts will be generated if both are zero */ if ((ec->tx_coalesce_usecs == 0) && (ec->tx_max_coalesced_frames == 0)) return -EINVAL;
