On Wed, Aug 31, 2016 at 12:14 PM, Eric Dumazet <[email protected]> wrote: > On Wed, 2016-08-31 at 10:56 +0800, [email protected] wrote: >> From: Gao Feng <[email protected]> >> >> The original codes depend on that the function parameters are evaluated from >> left to right. But the parameter's evaluation order is not defined in C >> standard actually. >> >> When flow_keys_have_l4(&keys) is invoked before ___skb_get_hash(skb, &keys, >> hashrnd) with some compilers or environment, the keys passed to >> flow_keys_have_l4 is not initialized. >> >> Signed-off-by: Gao Feng <[email protected]> >> --- > > Good catch, please add > > Fixes: 6db61d79c1e1 ("flow_dissector: Ignore flow dissector return value from > ___skb_get_hash") > Acked-by: Eric Dumazet <[email protected]> > >
Add it into the description and resend the patch again? Best Regards Feng
