----- Original Message -----
> From: "Linus Torvalds" <[email protected]>
> To: "Al Viro" <[email protected]>, "CAI Qian" <[email protected]>
> Cc: "Miklos Szeredi" <[email protected]>, "Rainer Weikusat" 
> <[email protected]>, "Hannes Frederic Sowa"
> <[email protected]>, "Rainer Weikusat" 
> <[email protected]>, "Eric Sandeen"
> <[email protected]>, "Network Development" <[email protected]>
> Sent: Thursday, September 1, 2016 6:04:38 PM
> Subject: Re: possible circular locking dependency detected
> 
> On Thu, Sep 1, 2016 at 2:43 PM, Linus Torvalds
> <[email protected]> wrote:
> > On Thu, Sep 1, 2016 at 2:01 PM, Al Viro <[email protected]> wrote:
> >>
> >> Outside as in "all fs activity in bind happens under it".  Along with
> >> assignment to ->u.addr, etc.  IOW, make it the outermost lock there.
> >
> > Hah, yes. I misunderstood you.
> >
> > Yes. In fact that fixes the problem I mentioned, rather than introducing
> > it.
> 
> So the easiest approach would seem to be to revert commit c845acb324aa
> ("af_unix: Fix splice-bind deadlock"), and then apply the lock split.
> 
> Like the attached two patches.
> 
> This is still *entirely* untested.
Tested-by: CAI Qian <[email protected]>
> 
> Rainer?
> 
>                  Linus
> 

Reply via email to