On 9/1/16 11:26 PM, Mark Tomlinson wrote: > When deleting an IP address from an interface, there is a clean-up of > routes which refer to this local address. However, there was no check to > see that the VRF matched. This meant that deletion wasn't confined to > the VRF it should have been. > > To solve this, a new field has been added to fib_info to hold a table > id. When removing fib entries corresponding to a local ip address, this > table id is also used in the comparison. > > The table id is populated when the fib_info is created. This was already > done in some places, but not in ip_rt_ioctl(). This has now been fixed. >
The best fixes tag is: Fixes: 021dd3b8a142 ("net: Add routes to the table associated with the device") > Signed-off-by: Mark Tomlinson <mark.tomlin...@alliedtelesis.co.nz> > --- > include/net/ip_fib.h | 3 ++- > net/ipv4/fib_frontend.c | 3 ++- > net/ipv4/fib_semantics.c | 8 ++++++-- > 3 files changed, 10 insertions(+), 4 deletions(-) Acked-by: David Ahern <d...@cumulusnetworks.com> Tested-by: David Ahern <d...@cumulusnetworks.com> Mark: send a v2 with the Fixes tag and my acked-by and tested-by. Thanks for the patch.