On 16-09-02 01:57 AM, Cong Wang wrote:

Cc: Jamal Hadi Salim <j...@mojatatu.com>
Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com>
---
 include/net/act_api.h |  2 ++
 net/sched/act_api.c   | 20 ++++++++++++++++++++
 2 files changed, 22 insertions(+)

diff --git a/include/net/act_api.h b/include/net/act_api.h
index 82f3c91..a374bab 100644
--- a/include/net/act_api.h


+void tcf_hash_replace(struct tc_action_net *tn, struct tc_action **old,
+                     struct tc_action *new, int bind)
+{
+       struct tcf_hashinfo *hinfo = tn->hinfo;
+       unsigned int h = tcf_hash(new->tcfa_index, hinfo->hmask);
+

WWhy do you need to recreate the index?
Old index was fine since this is just a replacement..

The rest of the patches seem fine - will let Eric comment on the
mirred.

Note: I am going to still push forward with skbmod action and I think
so should the new tunnel action code i.e we make them independent.
I'd like to switch to this when we think it is stable.

cheers,
jamal

Reply via email to