From: Yuval Mintz <yuval.mi...@qlogic.com> Date: Wed, 7 Sep 2016 11:55:34 +0000
>> We get a few warnings when building kernel with W=1: >> drivers/net/ethernet/qlogic/qed/qed_l2.c:112:5: warning: no previous >> prototype for 'qed_sp_vport_start' [-Wmissing-prototypes] >> .... >> >> In fact, these functions are only used in the file in which they are >> declared and don't need a declaration, but can be made static. >> so this patch marks these functions with 'static'. >> >> Signed-off-by: Baoyou Xie <baoyou....@linaro.org> > > Most of this changes are correct. I have 2 reservations, though: > > 1. qed_get_vport_stats() is in use in net-next by qed_main.c starting with > 6c75424612a7 ("qed: Add support for NCSI statistics."), so we shouldn't > make it static. > [This raises the question of which repository was this patch built against?] > > 2. Regarding the changes in qed_cxt.c - some of the functions you're turning > into static are going to be used be other files in our pending RoCE driver > submissions [you could say those ARE really missing their prototypes]. > I don't have a real objection to this change - I'm just stating that if you'll > change those now to static, we'll probably 'revert' the change in the near > future. Baoyou, please respin this against net-next, thanks.