On Thu, Sep 08, 2016 at 08:37:47AM -0700, Alexander Duyck wrote: > > A few minor things. > > First you somehow got a couple spaces in the line before gso_size. > That is why the two lines above don't line up. > > Second it occurred to me that we could have a situation where tail is > equal to segs in the case of GSO_PARTIAL with an MSS aligned frame. > To avoid doing duplicate division we might want to make the else an > "else if (tail != segs)" > > Finally I think the value for the division should be tail->len - > doffset, not tail->len as we shouldn't include the header data in the > size as it might cause us to report more packets then we actually > generate. > > I think that should cover all of it. Sorry for the thrash.
Never mind, I do a v5. Better one more iteration of review than a suboptimal patch.
