Tom Herbert <t...@herbertland.com> wrote: > > + nrslv->params.head_offset = offsetof(struct net_rslv_ent, node); > + nrslv->params.key_offset = offsetof(struct net_rslv_ent, object); > + nrslv->params.key_len = key_len; > + nrslv->params.max_size = max_size; > + nrslv->params.min_size = 256; > + nrslv->params.automatic_shrinking = true; > + nrslv->params.obj_cmpfn = cmp_fn ? net_rslv_cmp : NULL;
This completely defeats the rhashtable inlining since that relies on the parameter being constant. Looking at your next patch you have exactly one user for this. So who is going to be the next user and do we really need all these fields to be variable? Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
