Date: Tue, 20 Sep 2016 14:23:24 -0700, Florian Fainelli <f.faine...@gmail.com> wrote: >On 09/20/2016 12:59 AM, sean.w...@mediatek.com wrote: >> From: Sean Wang <sean.w...@mediatek.com> >> >> adds PHY-mode "trgmii" as an extension for the operation >> mode of the PHY interface, TRGMII can be compatible with >> RGMII, so the extended mode doesn't really have effects on >> the target MAC and PHY, is used as the indication if the >> current MAC is connected to an internal switch or external >> PHY respectively by the given configuration on the board and >> then to perform the corresponding setup on TRGMII hardware >> module. > >Based on my googling, it seems like Turbo RGMII is a Mediatek-specific >thing for now, but this could become standard and used by other vendors >at some point, so I would be inclined to just extend the phy-mode >property to support trgmii as another interface type. > >If you do so, do you also mind proposing an update to the Device Tree >specification: > >https://www.devicetree.org/specifications/ > >Thanks!
I am willing to do the these thing 1) in the next version, I will extend rgmii mode as another interface type as PHY_INTERFACE_MODE_TRGMII defined in linux/phy.h instead of extension only inside the current driver. This change also helps to save some code. 2) I send another separate patch for updating the Device Tree specification about TRGMII adding description are these all okay for you?
