> info->data = 0; > switch (info->flow_type) { > + case UDP_V4_FLOW: > + if (efx->rx_hash_udp_4tuple) > + /* fall through */ > + /* else fall further! */ > case TCP_V4_FLOW: > - info->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3; > + info->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3; > /* fall through */ > - case UDP_V4_FLOW: > case SCTP_V4_FLOW: > case AH_ESP_V4_FLOW: > case IPV4_FLOW: > info->data |= RXH_IP_SRC | RXH_IP_DST; > min_revision = EFX_REV_FALCON_B0; > break;
Well, you sure fulfilled your cover letter's promise. ;-) Do you really prefer this conditional mayham over copy-pasting some lines?