On Tue, 4 Oct 2016 19:03:46 -0700, Pravin Shelar wrote: > We could have encapsulated packet defragmented in physical bridge. > that mean the packet is entering OVS after egressing tunnel device. > That use case would break due to this patch.
Okay, thanks for explanation. I missed this use case and it would indeed break. And we can't clear existing inner headers when the frame enters the bridge as it would break GSO. Seems checking for the MPLS ethertype is indeed the only safe solution. > > If this patch is wrong, then the current push_mpls is wrong, too, it > > does the same assumption. > > > I am not sure what you mean, can you explain? push_mpls() uses inner_proto as an indication whether this is the first MPLS label or not. But it checks skb->encapsulation at the start, thus it's safe (I expected this check to be done at the config time, not runtime, and looked in the wrong place for it.) I'll respin the patch. Thanks for the patience with me, Jiri
