From: "Mintz, Yuval" <yuval.mi...@cavium.com>
Date: Mon, 10 Oct 2016 06:33:05 +0000
>
>> > + while (iter_cnt--) {
>> > + /* Validate we receive completion update */
>> > smp_rmb();
>> > if (comp_done->done == 1) {
>> > if (p_fw_ret)
>> > *p_fw_ret = comp_done->fw_return_code;
>> > return 0;
>> > }
>
>> Note that this smp_rmb() and accesses to ->done and ->fw_return_code are
>> racy.
>
>> fw_return_code needs to be written _before_ done.
>
> Thanks for catching this up.
>
> Dave - do you want me to re-spin for this?
Yes.
