From: Stefan Wahren <stefan.wah...@i2se.com> Date: Tue, 18 Oct 2016 13:27:34 +0200
> +void > +qca_tty_receive(struct tty_struct *tty, const unsigned char *cp, char *fp, > + int count) > +{ > + struct qcauart *qca = tty->disc_data; > + struct net_device_stats *n_stats = &qca->net_dev->stats; > + int dropped = 0; Please order local variable declarations from longest to shortest line. > +netdev_tx_t > +qcauart_netdev_xmit(struct sk_buff *skb, struct net_device *dev) > +{ > + struct qcauart *qca = netdev_priv(dev); > + struct net_device_stats *n_stats = &dev->stats; > + u8 *pos; > + u8 pad_len = 0; > + int written; Likewise.