From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 1 Jun 2006 21:15:04 +1000
> On Thu, Jun 01, 2006 at 10:25:25AM +1000, herbert wrote: > > > > > I think this netpoll wrinkle means we also have to make > > > sure to set the xmit_lock_owner across the board. > > > > You're right. In fact this can deadlock today for those drivers that > > already make use of xmit_lock without setting the owner. So I suppose > > something like net_xmit_lock to obtain xmit_lock is called for. > > OK, here is a patch which does this. > > [NET]: Add netif_tx_lock IPOIB is going to BUG() with this change. Because now, in their multicast code, you're going to local_bh_disable() via netif_tx_unlock() with hw IRQs disabled which is illegal. It shows a bug here in the locking of the IPOIB driver. We need to think about this change some more. :) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
