On Thu, Oct 27, 2016 at 03:25 PM GMT, David Miller wrote: > From: Jakub Sitnicki <j...@redhat.com> > Date: Mon, 24 Oct 2016 11:28:52 +0200 > >> + inner_iph = skb_header_pointer( >> + skb, skb_transport_offset(skb) + sizeof(*icmph), >> + sizeof(_inner_iph), &_inner_iph); > > Please do not style this call like this, put as many arguments as > you can on the first line. > > inner_iph = skb_header_pointer(skb, > skb_transport_offset(skb) + > sizeof(*icmph), > sizeof(_inner_iph), &_inner_iph); > > And on the second and subsequent lines, indent to the first column after > the openning parenthesis of the first line.
FWIW, I had it styled like that and then changed it. Will change back. In my defense - checkpatch.pl made me do it, Your Honor! (line too long)
