Florian Fainelli wrote:
So in premise, this is good, and is exactly what I have in mind for the series that I am cooking, but if we apply this alone, without a change in drivers/net/phy/phy.c which adds SUPPORTED_Pause | SUPPORTED_AsymPause to phydev->features, we are basically breaking the Ethernet MAC drivers that don't explicitly override phydev->features and yet rely on that to get flow control to work.
That's what I figured, but I wasn't sure how to handle that. However, isn't the ability to pass pause frames a feature that some PHYs do not have? That is, does every PHY support bits 10 and 11 in register 4?
-- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
