Andrew Lunn <and...@lunn.ch> writes: > On Fri, Nov 04, 2016 at 03:05:00PM +0000, Måns Rullgård wrote: >> Andrew Lunn <and...@lunn.ch> writes: >> >> >> > I agree with you. But fixing it is likely to break boards which >> >> > currently have "rgmii", but actually need the delay in order to work. >> >> >> >> Does the internal delay here refer to the PHY or the MAC? It's a >> >> property of the MAC node after all. >> > >> > It is the PHY which applies the delay. >> >> Says who? > > The source code.
There's source code that disagrees with that. The Broadcom GENET driver, for instance. >> Some MACs can do it too. > > I'm sure they can. But look at the code. Nearly none do, and those > that do are potentially broken. Those few drivers that do anything differently based on these values enable clock delay in the MAC. That's why I wrote the NB8800 driver the way I did. -- Måns Rullgård
