On Mon, 5 Jun 2006, David Miller wrote: > This patch doesn't make any sense, I've been over it a few times. > > The seqfile layer should take care of that user buffering issue transparently as > long as we implement the interface callbacks properly. > > Even if something needs to be fixed in the pneigh dumper, special casing *pos==1 > doesn't look right. Also, if pneigh has this problem, how come the neigh seqfile > iterators don't have the same problem or do they?
>From my analysis, the problem is that pneigh_get_next() ends up assigning pn to one entry ahead of what it should be pointing too. This only occurs when the user's read buffer fills up, where pneigh_get_idx() is called, which calls pneigh_get_next() until *pos is not true. I have not checked neigh seqfile iterators, the problem may exist in there as well. My patch solves this issue for us, however a more elegant solution would be most welcome. Could the root of the problem be that *pos is off by one when pneigh_get_idx() is called? Jari - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
