From: Madalin-Cristian Bucur <madalin.bu...@nxp.com> Date: Wed, 9 Nov 2016 17:16:12 +0000
>> From: Madalin-Cristian Bucur >> Sent: Monday, November 07, 2016 5:43 PM >> >> > From: David Miller [mailto:da...@davemloft.net] >> > Sent: Thursday, November 03, 2016 9:58 PM >> > >> > From: Madalin Bucur <madalin.bu...@nxp.com> >> > Date: Wed, 2 Nov 2016 22:17:26 +0200 >> > >> > > This introduces the Freescale Data Path Acceleration Architecture > <snip> > >> > > + int numstats = sizeof(struct rtnl_link_stats64) / sizeof(u64); >> > ... >> > > + cpustats = (u64 *)&percpu_priv->stats; >> > > + >> > > + for (j = 0; j < numstats; j++) >> > > + netstats[j] += cpustats[j]; >> > >> > This is a memcpy() on well-typed datastructures which requires no >> > casting or special handling whatsoever, so use memcpy instead of >> > needlessly open coding the operation. >> >> Will fix. > > Took a second look at this, it's not copying but adding the percpu > statistics into consolidated results. Ok, then it looks fine, thanks for clarifying.
