Hi Florian, On Mon, Nov 21, 2016 at 7:09 PM, Florian Westphal <f...@strlen.de> wrote: > f...@ikuai8.com <f...@ikuai8.com> wrote: >> From: Gao Feng <f...@ikuai8.com> >> >> The tc could return NET_XMIT_CN as one congestion notification, but >> it does not mean the packet is lost. Other modules like ipvlan, >> macvlan, and others treat NET_XMIT_CN as success too. >> >> So batman-adv should add the NET_XMIT_CN check. > > "The tc could return NET_XMIT_CN as one congestion notification, but > it means another packet got dropped. Other modules like batman do not > treat NET_XMIT_CN as success, so modules like ipvlan, macvlan, .. > should ignore it as well." > > What I am asking is: > Are you sure adding NET_XMIT_CN handling everywhere is the right way to > resolve the inconsistency?
Or create one new macro to handle this case like net_xmit_eval. For example, #define net_xmit_ok(ret) (ret == NET_XMIT_SUCCESS || ret == NET_XMIT_CN) Is it ok? But it should be done for net-next. Best Regards Feng
