On Wed, Nov 23, 2016 at 05:26:28AM -0800, Eric Dumazet wrote:
> On Wed, 2016-11-23 at 13:41 +0100, Phil Sutter wrote:
>
> > +struct vf_data_storage {
> > + unsigned char vf_mac[ETH_ALEN];
> > + u16 pf_vlan; /* When set, guest VLAN config not allowed. */
> > + u16 pf_qos;
> > + __be16 vlan_proto;
> > + u16 min_tx_rate;
> > + u16 max_tx_rate;
> > + u8 spoofchk_enabled;
> > + bool rss_query_enabled;
> > + u8 trusted;
> > + int link_state;
> > +};
>
> Could you use proper indentation of field names ?
Sure!
> struct vf_data_storage {
> u8 vf_mac[ETH_ALEN];
Also thanks for suggesting u8 here. I really shouldn't copy'n'paste
code, not even from a well-maintained driver.
Thanks, Phil
