Hi Andrew, Andrew Lunn <and...@lunn.ch> writes:
> @@ -3749,6 +3756,7 @@ static const struct mv88e6xxx_info mv88e6xxx_table[] = { > .global1_addr = 0x1b, > .age_time_coeff = 15000, > .g1_irqs = 9, > + .tag_protocol = DSA_TAG_PROTO_EDSA, > .flags = MV88E6XXX_FLAGS_FAMILY_6352, > .ops = &mv88e6172_ops, > }, Since some chips support several protocols, we will have to turn tag_protocol into a bitmask and introduce something like: enum mv88e6xxx_tag { MV88E6XXX_TAG_TRAILER = BIT(DSA_TAG_PROTO_TRAILER), MV88E6XXX_TAG_DSA = BIT(DSA_TAG_PROTO_DSA), MV88E6XXX_TAG_EDSA = BIT(DSA_TAG_PROTO_EDSA), }; But I guess it is OK to force a single one at the moment. Reviewed-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> Thanks, Vivien