On 12/09/2016 01:48 AM, Selvin Xavier wrote: > This patch implements support for create_cq, destroy_cq and req_notify_cq > verbs. > > Signed-off-by: Eddie Wai <eddie....@broadcom.com> > Signed-off-by: Devesh Sharma <devesh.sha...@broadcom.com> > Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> > Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> > Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> > --- > drivers/infiniband/hw/bnxtre/bnxt_qplib_fp.c | 183 > ++++++++++++++++++++++++ > drivers/infiniband/hw/bnxtre/bnxt_qplib_fp.h | 47 ++++++ > drivers/infiniband/hw/bnxtre/bnxt_re_ib_verbs.c | 154 ++++++++++++++++++++ > drivers/infiniband/hw/bnxtre/bnxt_re_ib_verbs.h | 19 +++ > drivers/infiniband/hw/bnxtre/bnxt_re_main.c | 4 + > include/uapi/rdma/bnxt_re_uverbs_abi.h | 11 ++ > 6 files changed, 418 insertions(+)
Something I just realized is this patch series does not modify the MAINTAINERS file. Whom from Broadcom will be maintaining this driver? Probably want to include this info in the v3 series [...] > diff --git a/drivers/infiniband/hw/bnxtre/bnxt_re_ib_verbs.c > b/drivers/infiniband/hw/bnxtre/bnxt_re_ib_verbs.c > index 3417829..f316598 100644 > --- a/drivers/infiniband/hw/bnxtre/bnxt_re_ib_verbs.c > +++ b/drivers/infiniband/hw/bnxtre/bnxt_re_ib_verbs.c > @@ -60,6 +60,16 @@ > #include "bnxt_re_ib_verbs.h" > #include <rdma/bnxt_re_uverbs_abi.h> > > +static int bnxt_re_copy_to_udata(struct bnxt_re_dev *rdev, void *data, int > len, > + struct ib_udata *udata) > +{ > + int rc; > + > + rc = ib_copy_to_udata(udata, data, len); > + > + return rc ? -EFAULT : 0; > +} This function seems to provide no value by wrapping ib_copy_to_udata, any reason to keep it? From the two call sites for this function it appears it can be replaced with a direct call to ib_copy_to_udata.