On Saturday 24 December 2016 19:14:21 Pavel Machek wrote: > On Sat 2016-12-24 17:53:00, Pali Rohár wrote: > > @@ -1581,10 +1598,16 @@ int wl1251_init_ieee80211(struct wl1251 > > *wl) > > > > wl->hw->queues = 4; > > > > + if (wl->nvs == NULL && !wl->use_eeprom) { > > + ret = wl1251_fetch_nvs(wl); > > + if (ret < 0) > > + goto out; > > + } > > Is goto out here good idea? IMNSHO it is copy&paste bug, it should > just proceed with generating random address.
No, goto is correct here. wl1251 cannot be initialized without NVS data. And when fetching (from userspace) fails it is fatal error. -- Pali Rohár pali.ro...@gmail.com
signature.asc
Description: This is a digitally signed message part.