From: Matthias Tafelmeier <matthias.tafelme...@gmx.net>
Date: Mon, 26 Dec 2016 17:43:08 +0100

> 
>> From: Matthias Tafelmeier <matthias.tafelme...@gmx.net>
>> Date: Mon, 26 Dec 2016 10:49:23 +0100
>>
>>> @@ -269,13 +269,21 @@ static struct ctl_table net_core_table[] = {
>>>             .extra1         = &min_rcvbuf,
>>>     },
>>>     {
>>> -           .procname       = "dev_weight",
>>> -           .data           = &weight_p,
>>> +           .procname       = "dev_weight_rx",
>>> +           .data           = &weight_p_rx,
>>  ...
>>>     {
>>> +           .procname       = "dev_weight_tx",
>> Sysctls are user visible APIs.  You cannot change them without
>> breaking userspace.  You particularly cannot change the name of
>> the sysctl.
> 
> What about leaving *dev_weight* in place for TX side as is and newly
> introducing a sysctl param
> *dev_weight_rx*. Though, am open to a better naming for the latter.

This changes behavior for existing users, you cannot do this.

Reply via email to