From: Aaron Conole <[email protected]>
Date: Tue, 03 Jan 2017 10:50:00 -0500
>> @@ -489,7 +490,12 @@ static int __inet_insert_ifa(struct in_ifaddr *ifa,
>> struct nlmsghdr *nlh,
>> Notifier will trigger FIB update, so that
>> listeners of netlink will know about new ifaddr */
>> rtmsg_ifa(RTM_NEWADDR, ifa, nlh, portid);
>> - blocking_notifier_call_chain(&inetaddr_chain, NETDEV_UP, ifa);
>> + ret = blocking_notifier_call_chain(&inetaddr_chain, NETDEV_UP, ifa);
>
> Why are you doing this assignment if you aren't using the result?
>
>> + ret = notifier_to_errno(ret);
>> + if (ret) {
>> + __inet_del_ifa(in_dev, ifap, 1, NULL, portid);
>> + return ret;
>> + }
'ret' assignment is being used, via notifier_to_errno().
