Tue, Jan 17, 2017 at 12:11:49PM CET, [email protected] wrote:
>From: Jamal Hadi Salim <[email protected]>
>
>Signed-off-by: Jamal Hadi Salim <[email protected]>
>---
[...]
>-static inline unsigned long
>-cls_set_class(struct tcf_proto *tp, unsigned long *clp,
>+static inline unsigned long cls_set_class(struct tcf_proto *tp,
>+ unsigned long *clp,
> unsigned long cl)
While you are at it, you can align this as well.
> {
> unsigned long old_cl;
>-
This empty line should definitelly stay.
> tcf_tree_lock(tp);
> old_cl = __cls_set_class(clp, cl);
> tcf_tree_unlock(tp);
>-
> return old_cl;
> }
>
[...]
>@@ -237,7 +232,6 @@ static inline int tcf_em_early_end(struct tcf_ematch *em,
>int result)
>
> return 0;
> }
>-
This empty line should stay.
> /**
> * struct tcf_ematch_tree - ematch tree handle
> *
>@@ -246,8 +240,7 @@ static inline int tcf_em_early_end(struct tcf_ematch *em,
>int result)
> */
> struct tcf_ematch_tree {
> struct tcf_ematch_tree_hdr hdr;
>- struct tcf_ematch * matches;
>-
>+ struct tcf_ematch *matches;
Well, to be pedantic, this still looks odd :)
> };
