On 01/18/2017 07:53 AM, Zefir Kurtisi wrote:
No, not necessarily. The SGMII link default configuration is set such that you
do
not have to bother at all.
Does the SGMII link need to make the speed and duplex of the external link?
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c#n50
Here is where I can configure the SGMII link to match whatever phydev says
the external link is. This is code that was handed down to me. I've never
really understood what the purpose was. Shouldn't I just be able to
configure the SGMII link to 1Gbs full-duplex, regardless of what the external
link is set to?
That is, if in your case you see the warning popping up but the link always
regains connection, then it is an ignorable false positive.
Unfortunately, I can't really ignore it because genphy does this:
$ ifup eth1
[ 1034.754276] qcom-emac QCOM8070:00 eth1: Link is Up - 1Gbps/Full - flow
control rx/tx
But the at803x driver does this:
$ ifup eth1
[ 1020.507728] 803x_aneg_done: SGMII link is not ok
[ 1020.513517] qcom-emac QCOM8070:00 eth1: Link is Up - 1Gbps/Full - flow
control rx/tx
[ 1020.522839] qcom-emac QCOM8070:00 eth1: Link is Up - 1Gbps/Full - flow
control rx/tx
Customers are going to complain.
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
