On Mon, 26 Jun 2006 12:02:21 -0700
"Ron Mercer" <[EMAIL PROTECTED]> wrote:
> The attached patch fixes the compile bugs you indicated plus some of
> Jeff Garzik's concerns.
>
> - Removed non-NAPI code.
> - Removed un-needed PCI_POSTING macro.
> - Converted msleep() to ssleep() where waiting > 1 sec.
> - Broke up ql_link_state_machine into two functions for indent purposes.
> - Cleaned up ql3xxx_remove().
> - Cleaned up banner print and moved to probe.
> - Got rid of tx_lock. Not needed.
> - Fix send routine for big endian mapping problem.
> - Version change to k35.
>
> Built and tested on the latest git tree on x86 and PPC64 platforms.
Thanks.
Is the device hotpluggable? If so, this:
qdev->index = cards_found;
in the probe() handler might do odd things - it'll just keep increasing as
the card is removed and re-added.
iirc, that's a common problem with net drivers. AFAICT it'll cause only
cosmetic oddities here.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
