On Tue, 24 Jan 2017 16:30:05 -0500 (EST)
David Miller <da...@davemloft.net> wrote:
> From: Stephen Hemminger <step...@networkplumber.org>
> Date: Tue, 24 Jan 2017 13:05:57 -0800
>
> > Lots of little things in here. Support for minor more ethtool control,
> > negotiation of offload parameters with host (based on FreeBSD) and
> > several cleanups.
>
> Series applied, but two comments for potential follow-on changes:
>
> > netvsc: enhance transmit select_queue
>
> Wouldn't it be better to check for the channel table NULL pointer
> before assigning the queue index to the socket?
Wanted to keep the original ordering out of paranoia.
> > netvsc: call netif_receive_skb
>
> Hmmm, potential stack depth issues?
No more of an issue than net softirq before (ie process_backlog).
The call chain is:
tasklet_action
vmbus_on_event ... process_chn_event
netvsc_channel_cb ... netif_receive_skb
NAPI/GRO support is possible but needs changes in VMBUS core code.
