On Thu, Jan 26, 2017 at 01:01:06PM +0100, Gregory CLEMENT wrote: > Hi Andrew, > > On mer., janv. 25 2017, Andrew Lunn <and...@lunn.ch> wrote: > > > > diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c > > index b5b73ff4329a..9debe1a4a6f6 100644 > > --- a/drivers/net/phy/marvell.c > > +++ b/drivers/net/phy/marvell.c > > @@ -2140,6 +2140,25 @@ static struct phy_driver marvell_drivers[] = { > > .get_strings = marvell_get_strings, > > .get_stats = marvell_get_stats, > > }, > > + { > > + .phy_id = MARVELL_PHY_ID_88E6390, > > + .phy_id_mask = MARVELL_PHY_ID_MASK, > > + .name = "Marvell 88E6390", > > + .features = PHY_GBIT_FEATURES, > > + .flags = PHY_HAS_INTERRUPT, > > + .probe = marvell_probe, > > In order to get the temperature support I also had to modify the line > above by using m88e1510_probe instead of the marvell_probe. Indeed the > hwmon register was not done marvell_probe.
Yes, this is historic. These patches come from one branch where i have all my mv88e6390 code. I had them in the opposite order to what we have now. I had this PHY work around first, and then the temperature sensor move patches. But to get the code into mainline, i pulled the patches apart. The temperature code has hit mainline first, now follow the PHY ID workaround. I need to fix this probe call as a result. Although the temperature sensor does not work yet for the 6390, i'm going to assume it will at some point work. So i think it is O.K. to use the same ID, and have the 6390 PHYs return -25000mC until we figure out what is wrong. Andrew