On 26/01/17 19:36, David Miller wrote:
> From: Edward Cree <ec...@solarflare.com>
> Date: Thu, 26 Jan 2017 17:53:48 +0000
>
>> diff --git a/drivers/net/ethernet/sfc/net_driver.h
>> b/drivers/net/ethernet/sfc/net_driver.h
>> index 5927c20..c640955 100644
>> --- a/drivers/net/ethernet/sfc/net_driver.h
>> +++ b/drivers/net/ethernet/sfc/net_driver.h
>> @@ -51,6 +51,15 @@
>> #define EFX_WARN_ON_PARANOID(x) do {} while (0)
>> #endif
>>
>> +/* if @cond then downgrade to debug, else print at @level */
>> +#define netif_cond_dbg(priv, type, netdev, cond, level, fmt, args...) \
>> + do { \
>> + if (cond) \
>> + netif_dbg(priv, type, netdev, fmt, ##args); \
>> + else \
>> + netif_ ## level(priv, type, netdev, fmt, ##args); \
>> + } while (0)
>> +
>> /**************************************************************************
>> *
>> * Efx data structures
>>
> Please do not define locally in a driver an interface that looks like a
> generic
> one and might be useful to code outside of your driver.
>
> Thanks.
Sure. I'll put this in netdevice.h and respin.
-Ed
