On Fri, Jan 27, 2017 at 10:05:58PM +0300, Sergei Shtylyov wrote: > On 01/27/2017 09:35 PM, Simon Horman wrote: > > >From: Kazuya Mizuguchi <kazuya.mizuguchi...@renesas.com> > > > >This patch enables tx and rx clock internal delay modes (TDM and RDM). > > > >This is to address a failure in the case of 1Gbps communication using the > >by salvator-x board with the KSZ9031RNX phy. This has been reported to > >occur with both the r8a7795 (H3) and r8a7796 (M3-W) SoCs. > > > >With this change APSR internal delay modes are enabled for > >"rgmii-id", "rgmii-rxid" and "rgmii-txid" phy modes as follows: > > > >phy mode | ASPR delay mode > >-----------+---------------- > >rgmii-id | TDM and RDM > >rgmii-rxid | RDM > >rgmii-txid | TDM > > > >Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi...@renesas.com> > >Signed-off-by: Simon Horman <horms+rene...@verge.net.au> > > Acked-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> > > >--- > >v2 [Simon Horman] > >* As suggested by Sergei Shtylyov > > - Add a comment to indicate that APSR_DM appears to be undocumented. > > - Move chip_id check outside of ravb_set_delay_mode for consistency > > - Call ravb_modify() once in ravb_set_delay_mode() > >* Enhance comment before calls to ravb_set_delay_mode() > > Well, I meant to say that the comment should precede the body of the > function, not be repeated at every call...
I scratched my head trying to work out what you meant... and guessed wrong. > >* Remove unnecessary break from end of switch statement. > > Come on, you did remove all the *switch*. :-) Yes, after I wrote the comment above :)
