On Tue, Jun 27, 2006 at 09:37:01PM -0700, Michael Chan wrote:
> 
> Signed-off-by: Michael Chan <[EMAIL PROTECTED]>

Looks good to me too!

> @@ -56,6 +55,9 @@ static inline void TCP_ECN_send(struct s
>                       if (tp->ecn_flags&TCP_ECN_QUEUE_CWR) {
>                               tp->ecn_flags &= ~TCP_ECN_QUEUE_CWR;
>                               skb->h.th->cwr = 1;
> +                             if (skb_shinfo(skb)->gso_type & SKB_GSO_TCPV4)
> +                                     skb_shinfo(skb)->gso_type |=
> +                                             SKB_GSO_TCPV4_ECN;

As a byte-pincher I must suggest that you turn this check into something
like 

                                if (skb_shinfo(skb)->gso_type)

or even

                                if (skb_shinfo(skb)->gso_size)

:)

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to