HI Cong,
Have you posted any patch for the same? I am looking for single netlink
socket to handle multiple network namespace events using
NETLINK_LISTEN_ALL_NSID. I don't see detection of new namespaces by this socket
yet and causing updates to be missed.
Thanks
Krishna Mohan.
-----Original Message-----
From: [email protected] [mailto:[email protected]] On
Behalf Of Cong Wang
Sent: Thursday, October 20, 2016 1:37 AM
To: Elad Raz <[email protected]>
Cc: Nicolas Dichtel <[email protected]>; David Miller
<[email protected]>; Linux Netdev List <[email protected]>; Jiri Pirko
<[email protected]>; Ido Schimmel <[email protected]>; Yotam Gigi
<[email protected]>
Subject: Re: [Patch net-next 2/2] netns: avoid disabling irq for netns id
On Wed, Oct 19, 2016 at 8:21 AM, Elad Raz <[email protected]> wrote:
> On Fri, Sep 2, 2016 at 11:12 AM, Nicolas Dichtel
> <[email protected]> wrote:
>> Le 02/09/2016 à 06:53, Cong Wang a écrit :
>>> We never read or change netns id in hardirq context, the only place
>>> we read netns id in softirq context is in vxlan_xmit(). So, it
>>> should be enough to just disable BH.
>>
>> Are you sure? Did you audit all part of the code?
>> peernet2id() is called from netlink core system (do_one_broadcast()).
>> Are you sure that no driver call this function from an hard irq context?
>>
>> I think that NETLINK_LISTEN_ALL_NSID is largely untested, so it will
>> be hard to detect a bug introduced in this feature.
>
> I'm seeing strange things on our systems on boot time when trying to
> mount autofs.
> I bisected and got this patch as the bad one.
> I can see that only when I'm using "debug" config file.
Yeah, I saw the same report from SELinux developers, I am working on a fix.
Thanks.
