On 02/03/2017 10:20 AM, Vivien Didelot wrote:
> Simplify the code handling the slave netdevice notifier call by
> providing a dsa_slave_changeupper helper for NETDEV_CHANGEUPPER, and so
> on (only this event is supported at the moment.)
>
> Return NOTIFY_DONE when we did not care about an event, and NOTIFY_OK
> when we were concerned but no error occurred, as the API suggests.
>
> Signed-off-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com>
> ---
> static int dsa_slave_netdevice_event(struct notifier_block *nb,
> @@ -1529,8 +1514,11 @@ static int dsa_slave_netdevice_event(struct
> notifier_block *nb,
> {
> struct net_device *dev = netdev_notifier_info_to_dev(ptr);
>
> - if (dsa_slave_dev_check(dev))
> - return dsa_slave_port_event(dev, event, ptr);
> + if (dev->netdev_ops != &dsa_slave_netdev_ops)
> + return NOTIFY_DONE;
Why not keep the dsa_slave_dev_check() here?
--
Florian
