On Wed, Feb 08, 2017 at 07:48:01PM -0200, Marcelo Ricardo Leitner wrote:
> Hi Xin,
>
> On Thu, Feb 09, 2017 at 01:18:18AM +0800, Xin Long wrote:
> > This patch is to implement Sender-Side Procedures for the SSN/TSN
> > Reset Request Parameter descibed in rfc6525 section 5.1.4.
> >
> > It is also to add sockopt SCTP_RESET_ASSOC in rfc6525 section 6.3.3
> > for users.
> >
> > Signed-off-by: Xin Long <lucien....@gmail.com>
> ...
> > +
> > +int sctp_send_reset_assoc(struct sctp_association *asoc)
> > +{
> > + struct sctp_chunk *chunk = NULL;
> > + int retval;
> > + __u16 i;
> > +
> > + if (!asoc->peer.reconf_capable ||
> > + !(asoc->strreset_enable & SCTP_ENABLE_RESET_ASSOC_REQ))
> > + return -ENOPROTOOPT;
> > +
> > + if (asoc->strreset_outstanding)
> > + return -EINPROGRESS;
> > +
> > + chunk = sctp_make_strreset_tsnreq(asoc);
> ^--- refcnf = 1 (as per sctp_chunkify())
>
> > + if (!chunk)
> > + return -ENOMEM;
> > +
> > + /* Block further xmit of data until this request is completed */
> > + for (i = 0; i < asoc->stream->outcnt; i++)
> > + asoc->stream->out[i].state = SCTP_STREAM_CLOSED;
> > +
> > + asoc->strreset_chunk = chunk;
> > + sctp_chunk_hold(asoc->strreset_chunk);
> ^--- refcnf = 2
> > +
> > + retval = sctp_send_reconf(asoc, chunk);
> > + if (retval) {
> > + sctp_chunk_put(asoc->strreset_chunk);
> ^--- refcnf = 1
>
> Won't we leak the chunk here?
No we won't, sctp_send_reconf() frees it for us, aye.
