Thu, Feb 09, 2017 at 07:27:10PM CET, j...@mojatatu.com wrote:
>On 17-02-09 08:38 AM, Jiri Pirko wrote:
>> From: Jiri Pirko <j...@mellanox.com>
>>
>> Curly braces need to be there, for stylistic reasons.
>>
>> Signed-off-by: Jiri Pirko <j...@mellanox.com>
>> ---
>> net/sched/cls_api.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
>> index f44378c..48864ad 100644
>> --- a/net/sched/cls_api.c
>> +++ b/net/sched/cls_api.c
>> @@ -315,8 +315,9 @@ static int tc_ctl_tfilter(struct sk_buff *skb, struct
>> nlmsghdr *n)
>> err = -EINVAL;
>> goto errout;
>> }
>> - } else
>> + } else {
>> tp = NULL;
>> + }
>> break;
>> }
>> }
>>
>
>Jiri, shall we engage in a long discussion about which rule says that
>you can put braces around one line branching? ;->
scripts/checkpatch.pl :)
>
>Acked-by: Jamal Hadi Salim <j...@mojatatu.com>
>
>cheers,
>jamal
