On Mon, Feb 13, 2017 at 3:22 PM, Eric Dumazet <eduma...@google.com> wrote: > On Mon, Feb 13, 2017 at 3:16 PM, Alexander Duyck > <alexander.du...@gmail.com> wrote: > >> Any plans to add the bulk page count updates back at some point? I >> just got around to adding it for igb in commit bd4171a5d4c2 ("igb: >> update code to better handle incrementing page count"). I should have >> patches for ixgbe, i40e, and i40evf here pretty soon. That was one of >> the reasons why I implemented __page_frag_cache_drain in the first >> place. As I'm sure Jesper will probably point out the atomic op for >> get_page/page_ref_inc can be pretty expensive if I recall correctly. > > As a matter of fact I did this last week, but could not show any > improvement on one TCP flow, > so decided to not include this in this patch series. > > Maybe the issue was more a sender issue, I might revisit this later.
Odds are for a single TCP flow you won't notice. This tends to be more of a small packets type performance issue. If you hammer on he Rx using pktgen you would be more likely to see it. Anyway patch looks fine from a functional perspective so I am okay with it. The page count bulking is something that can be addressed later. Thanks. - Alex