On 2017-02-15 at 11:28:08 +0100, Joe Perches <j...@perches.com> wrote: > On Tue, 2017-02-14 at 15:10 +0100, Tobias Klauser wrote: > > hip04_get_stats() just returns dev->stats so we can leave it > > out altogether and let dev_get_stats() do the job. > > This could be done for at least a few more drivers: > > drivers/net/ethernet/chelsio/cxgb/sge.c
I don't see an .ndo_get_stats being defined/set in this file. AFAICT, this driver sets .ndo_get_stats to t1_get_stats(), which does some additional extraction of statistics from device registers and thus shouldn't be removed. > drivers/net/ethernet/intel/e1000/e1000_main.c > drivers/net/ethernet/intel/ixgb/ixgb_main.c Will cover these in follow-up patches, thanks. > drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c A patch for pch_gbe already landed in net-next.
