On Tue, Feb 07, 2017 at 07:10:26PM +0530, Raju Lakkaraju wrote: > From: Raju Lakkaraju <raju.lakkar...@microsemi.com> > > LED Mode: > Microsemi PHY support 2 LEDs (LED[0] and LED[1]) to display different > status information that can be selected by setting LED mode. > > LED Mode parameter (vsc8531, led-0-mode) and (vsc8531, led-1-mode) get > from Device Tree. > > Signed-off-by: Raju Lakkaraju <raju.lakkar...@microsemi.com> > --- > Change set: > v0: > - Initial version of LED driver for Microsemi PHYs. > v1: > - Update all review comments given by Andrew. > - Add new header file "mscc-phy-vsc8531.h" to define DT macros. > - Add error/range check for DT LED mode input > v2: > - Fixed x86_64 build error. > v3: > - Update all review comments. > - Fix the error check condition. > > .../devicetree/bindings/net/mscc-phy-vsc8531.txt | 10 +++ > drivers/net/phy/mscc.c | 85 > +++++++++++++++++++++- > include/dt-bindings/net/mscc-phy-vsc8531.h | 29 ++++++++ > 3 files changed, 123 insertions(+), 1 deletion(-) > create mode 100644 include/dt-bindings/net/mscc-phy-vsc8531.h > > diff --git a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt > b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt > index bdefefc6..0eedabe 100644 > --- a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt > +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt > @@ -27,6 +27,14 @@ Optional properties: > 'vddmac'. > Default value is 0%. > Ref: Table:1 - Edge rate change (below). > +- vsc8531,led-0-mode : LED mode. Specify how the LED[0] should behave. > + Allowed values are define in > + "include/dt-bindings/net/mscc-phy-vsc8531.h". > + Default value is VSC8531_LINK_1000_ACTIVITY (1). > +- vsc8531,led-1-mode : LED mode. Specify how the LED[1] should behave.
You failed to address my comment on v2. vsc8531 is not a vendor prefix. Please fix in a new patch since David already applied it. Rob
