Reported-by: Dan Carpenter <dan.carpen...@oracle.com>

Signed-off-by: Madalin Bucur <madalin.bu...@nxp.com>
---
 drivers/net/ethernet/freescale/fman/fman_port.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fman/fman_port.c 
b/drivers/net/ethernet/freescale/fman/fman_port.c
index f314348..57bf44f 100644
--- a/drivers/net/ethernet/freescale/fman/fman_port.c
+++ b/drivers/net/ethernet/freescale/fman/fman_port.c
@@ -1312,7 +1312,7 @@ int fman_port_config(struct fman_port *port, struct 
fman_port_params *params)
        /* Allocate the FM driver's parameters structure */
        port->cfg = kzalloc(sizeof(*port->cfg), GFP_KERNEL);
        if (!port->cfg)
-               goto err_params;
+               return -EINVAL;
 
        /* Initialize FM port parameters which will be kept by the driver */
        port->port_type = port->dts_params.type;
@@ -1393,8 +1393,6 @@ int fman_port_config(struct fman_port *port, struct 
fman_port_params *params)
 
 err_port_cfg:
        kfree(port->cfg);
-err_params:
-       kfree(port);
        return -EINVAL;
 }
 EXPORT_SYMBOL(fman_port_config);
-- 
2.1.0

Reply via email to