On Tue, Mar 21, 2017 at 04:10:26PM +0100, Jonas Bonn wrote: > On 03/21/2017 04:07 PM, Pablo Neira Ayuso wrote: > >On Tue, Mar 21, 2017 at 04:04:29PM +0100, Jonas Bonn wrote: > >>diff --git a/include/uapi/linux/gtp.h b/include/uapi/linux/gtp.h > >>index 72a04a0..c51ebb0 100644 > >>--- a/include/uapi/linux/gtp.h > >>+++ b/include/uapi/linux/gtp.h > >>@@ -19,7 +19,7 @@ enum gtp_attrs { > >> GTPA_LINK, > >> GTPA_VERSION, > >> GTPA_TID, /* for GTPv0 only */ > >>- GTPA_SGSN_ADDRESS, > >>+ GTPA_PEER_ADDRESS, /* Remote GSN peer, either SGSN or GGSN */ > >We need here: > > > >#define GTPA_SGSN_ADDRESS GTPA_PEER_ADDRESS > > > >for backward compatibility. Anything that is exposed through uapi > >cannot be changed. > > Yes... look a couple of lines further down... > > >> GTPA_MS_ADDRESS, > >> GTPA_FLOW, > >> GTPA_NET_NS_FD, > >>@@ -29,5 +29,6 @@ enum gtp_attrs { > >> __GTPA_MAX, > >> }; > >> #define GTPA_MAX (__GTPA_MAX + 1) > >>+#define GTPA_SGSN_ADDRESS GTPA_PEER_ADDRESS /* maintain legacy attr name */ > > ^^^^... there it is! :)
Oh right! Please, move it there to the enum definition, just after the new GTPA_PEER_ADDRESS. We usually do this in other areas of the networking code. You also have to resubmit indicating net-next in your patch subject, ie. [PATCH net-next v3 1/2] gtp: rename SGSN netlink attribute David usually requests that you explicitly indicate the target tree in some way. Thanks!