On 03/24/2017 01:15 PM, Harald Welte wrote:
looks fine to me, but I haven't tested it. Did you manually test it using the extended libgtpnl + tools?Also, in code like this: + if (gtp->role == GTP_ROLE_SGSN) { + pctx = ipv4_pdp_find(gtp, iph->saddr); + } else { I think general Linux kernel coding style is to not have curly-brackets around single-line blocks. See "Do not unnecessarily use braces where a single statement will do." in line 169 of Documentation/process/coding-style.rst
See line 191 in the same file for the exception. :-) [...] MBR, Sergei
