On 03/27/2017 11:12 AM, Joao Pinto wrote: > Às 10:09 AM de 3/27/2017, Corentin Labbe escreveu: >> On Mon, Mar 27, 2017 at 10:04:57AM +0100, Joao Pinto wrote: >>> Às 7:26 AM de 3/25/2017, Corentin Labbe escreveu: >>>> On Fri, Mar 24, 2017 at 05:16:45PM +0000, Joao Pinto wrote: >>>>> For cores that have more than 1 TX queue configured, the kernel would >>>>> crash, >>>>> since only one TX queue is permitted by default. >>>>> >>>>> Signed-off-by: Joao Pinto <jpi...@synopsys.com> >>>>> --- >>>>> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >>>>> b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >>>>> index 3827952..1eab084 100644 >>>>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >>>>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >>>>> @@ -3429,7 +3429,7 @@ static int stmmac_poll(struct napi_struct *napi, >>>>> int budget) >>>>> struct stmmac_rx_queue *rx_q = >>>>> container_of(napi, struct stmmac_rx_queue, napi); >>>>> struct stmmac_priv *priv = rx_q->priv_data; >>>>> - u32 tx_count = priv->dma_cap.number_tx_queues; >>>>> + u32 tx_count = priv->plat->tx_queues_to_use; >>>>> u32 chan = rx_q->queue_index; >>>>> u32 work_done = 0; >>>>> u32 queue = 0; >>>>> -- >>>>> 2.9.3 >>>>> >>>> >>>> This patch fix the performance issue on dwmac-sun8i only. >>> >>> Ok, great! >>> >> >> Sorry, in the we, I see that my gigabit dwmac-sun8i didnt work... (but didnt >> have time to find why). >> >>>> The dwmac-sunxi is still broken. > > Ok, let's see what others report. > >>>> >>> >>> What is the difference between the setups? >> >> dwmac-sun8i use chain mode, dwmac-sunxi use ring mode >> > > @Thierry and Niklas: Hi! Your setup is working well with these 2 fix patches? >
Hello Joao, I have not tested these 2 patches. Previously, when I tested next-20170321, artpec-6 SoC got TX queue timeouts. When testing today's linux-next, next-20170327, things are working again :) So I guess one of the following patches fixed our problem: 270c7759fbbc net: stmmac: add set_mac to the stmmac_ops b4f0a6615556 net: stmmac: fix dma operation mode config for older versions 33e85b8dd69e net: stmmac: Restore DT backwards-compatibility f39768744fd6 net: stmmac: Always enable MAC RX queues abe80fdc6ee6 net: stmmac: RX queue routing configuration a8f5102af2a7 net: stmmac: TX and RX queue priority configuration aff3d9eff843 net: stmmac: enable multiple buffers Regards, Niklas
